Repository navigation
Report registered components in Fantom view manager queries - #60129
Open
jipeng6036-del wants to merge 1 commit into
Open
jipeng6036-del wants to merge 1 commit into
jipeng6036-del wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #60064.
Make Fantom's view manager lookup use the same component descriptor providers as its renderer. It applies the renderer's name normalization, so
ViewandRCTViewresolve to the registered provider. Unknown names still returnfalse.Thanks to @YevheniiKotyrlo for the reproduction. Codex helped implement and verify this change.
Changelog
[INTERNAL] [FIXED] - Report registered view managers in Fantom.
Test Plan
yarn fantom --runInBand packages/react-native/Libraries/ReactNative/__tests__/HasViewManagerConfig-itest.jsreproduced the incorrectfalseforView. The unregistered-name control passed.yarn workspace @react-native/fantom buildand ranyarn fantom --runInBand packages/react-native/Libraries/ReactNative/__tests__. All 7 tests passed, including the registered name, legacy alias, and unregistered name cases.yarn eslint --max-warnings 0andyarn prettier --checkon the new test, andclang-format --dry-run --Werroron the three changed C++ files.